Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pkg): change sets to hashsets #11300

Merged
merged 1 commit into from
Jan 18, 2025
Merged

refactor(pkg): change sets to hashsets #11300

merged 1 commit into from
Jan 18, 2025

Conversation

rgrinberg
Copy link
Member

@rgrinberg rgrinberg commented Jan 14, 2025 •
edited
Loading

main:

Benchmark 1: ~/github/ocaml/dune/_build/default/bin/main.exe pkg lock
  Time (mean ± σ):      2.140 s ±  0.050 s    [User: 1.384 s, System: 0.501 s]
  Range (min … max):    2.078 s …  2.245 s    10 runs

PR:

Benchmark 1: ~/github/ocaml/dune/_build/default/bin/main.exe pkg lock
  Time (mean ± σ):      2.127 s ±  0.121 s    [User: 1.345 s, System: 0.490 s]
  Range (min … max):    2.055 s …  2.466 s    10 runs

@rgrinberg rgrinberg force-pushed the ps/rr/refactor_pkg___change_sets_to_hashsets branch from c56e421 to b840604 Compare January 17, 2025 00:20
@rgrinberg
refactor(pkg): change sets to hashsets
801004e 
Signed-off-by: Rudi Grinberg <[email protected]>

<!-- ps-id: aec1d5e4-e558-49b4-87f4-3e45bd59b7ba -->

Signed-off-by: Rudi Grinberg <[email protected]>
@rgrinberg rgrinberg force-pushed the ps/rr/refactor_pkg___change_sets_to_hashsets branch from b840604 to 801004e Compare January 18, 2025 16:12
@rgrinberg rgrinberg merged commit 558abc0 into main Jan 18, 2025
26 of 27 checks passed
@rgrinberg rgrinberg deleted the ps/rr/refactor_pkg___change_sets_to_hashsets branch January 18, 2025 16:29
ElectreAAS pushed a commit to ElectreAAS/dune that referenced this pull request Jan 27, 2025
@rgrinberg @ElectreAAS
refactor(pkg): change sets to hashsets (ocaml#11300)
9660808 
Signed-off-by: Rudi Grinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rgrinberg